Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ControlEditorPopupButton arrow position in RTL language #97996

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix ControlEditorPopupButton arrow position in RTL language #97996

merged 1 commit into from
Oct 14, 2024

Conversation

timothyqiu
Copy link
Member

The arrow is custom drawn and was not adapted to RTL layout.

Before After
ksnip_20241009-090058 ksnip_20241009-090056

Also removed one redundant header include in that cpp file.

@timothyqiu timothyqiu added bug topic:editor cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 9, 2024
@timothyqiu timothyqiu added this to the 4.4 milestone Oct 9, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner October 9, 2024 01:03
@Repiteo Repiteo merged commit a7b4e67 into godotengine:master Oct 14, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 14, 2024

Thanks!

@timothyqiu timothyqiu deleted the rtl-arrow branch October 14, 2024 23:50
@Spartan322 Spartan322 mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @Repiteo @bruvzg